stream: change the visibility of stream adaptor structures to public #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pub to all use declarations in stream_ext.rs, except for Collect as it should stay private, as stated in its doc. Fixes: #6656
|
Looks like I need some time to understand the visibility error :/ |
|
You don't have to open a new PR if the build fails. You can push additional commits to an existing PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pub to all use declarations in stream_ext.rs, except for Collect as it should stay private, as stated in its doc.
Fixes: #6656
Motivation
The
StreamExttrait provides the helpful methodtake,map, and the like onStreams. But the structures themselves (Take,Map, etc.) are not visible outside the crate, as they are notpub useinstream_ext.rs.Solution
Added pub to all use declarations in stream_ext.rs, except for Collect as it should stay private, as stated in its doc.