Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: use MetricAtomic* for task counters #6624

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jun 9, 2024

Follow-up PR to #6114 that uses #6598.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-metrics Module: tokio/runtime/metrics labels Jun 9, 2024
@Darksonn Darksonn requested a review from mox692 June 9, 2024 11:54
@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Jun 9, 2024
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than ci failure, looks good to me.

@Darksonn Darksonn enabled auto-merge (squash) June 10, 2024 08:46
@Darksonn Darksonn merged commit 9a75d6f into master Jun 17, 2024
83 checks passed
@Darksonn Darksonn deleted the alice/metric-atomic-for-task-counters branch June 17, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-metrics Module: tokio/runtime/metrics R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants