docs: stdin is always inherit by default
#6581
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for `output` indicates that only sets `stdout` and `stderr` (as one would expect, IMO), yet the docs for `stdin` indicated that it too would be set. This seems like it was just a simple copy/paste typo, so correct `stdin` to note that it just defaults to `inherit`. Fixes #6577.
Darksonn
added
A-tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
outputindicates that only setsstdoutandstderr(as one would expect, IMO), yet the docs forstdinindicated that it too would be set. This seems like it was just a simple copy/paste typo, so correctstdinto note that it just defaults toinherit.Fixes #6577.
Motivation
See #6577; the docs for
stdinseem to disagree with the code foroutput.Solution
Adjust the documentation to match the code.