Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add spawn_blocking and spawn_blocking_on to the JoinSet builder #6578

Merged
merged 2 commits into from
May 22, 2024
Merged

feat: add spawn_blocking and spawn_blocking_on to the JoinSet builder #6578

merged 2 commits into from
May 22, 2024

Conversation

hi-rustin
Copy link
Contributor

Motivation

close #6565

Solution

  1. Added the spawn_blocking API to the builder.
  2. Added the spawn_blocking_on API to the builder.

hi-rustin
hi-rustin commented May 22, 2024
View reviewed changes
Copy link
Contributor Author

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

Darksonn
Darksonn approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@Darksonn Darksonn merged commit e62c3e9 into tokio-rs:master May 22, 2024
77 checks passed
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-task Module: tokio/task labels May 22, 2024
@hi-rustin hi-rustin deleted the rustin-patch-builder branch May 22, 2024 11:40
@hi-rustin
Copy link
Contributor Author

Thanks for your review! 💚 💙 💜 💛 ❤️

@Darksonn Darksonn mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing methods join_set::Builder::spawn_blocking() and join_set::Builder::spawn_blocking_on()
2 participants
@hi-rustin @Darksonn