util: make WakeList::wake_all
use FIFO ordering
#6521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#6517 (comment) noted that the current implementation of
WakeList::wake_all
is LIFO, while the original pre-WakeList
implementations were FIFO. The very first implementation ofWakeList
was FIFO, but it also was also unsound in the case theWaker
panicked, so it was changed to work as it is currently implemented.Solution
This changes
WakeList
to be FIFO by processingWaker
s in order and using aDropGuard
to handle panics.