Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: small implementation cleanups #6517

Merged
merged 11 commits into from
May 1, 2024
Merged

time: small implementation cleanups #6517

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bda0d8f
time: use `compare_exchange_weak` in `StateCell::mark_pending`
paolobarbolini Apr 25, 2024
47a8f06
time: use `saturating_duration_since` in `TimeSource::instant_to_tick`
paolobarbolini Apr 25, 2024
a76b09c
time: use `array::from_fn` in `Level::new`
paolobarbolini Apr 25, 2024
79559ac
time: use array instead of `Vec` in `Wheel::levels`
paolobarbolini Apr 25, 2024
2ccecf8
time: use `Try` operator in `Level::next_expiration`
paolobarbolini Apr 25, 2024
404aafc
time: use constant instead of hard-coded values
paolobarbolini Apr 25, 2024
368a4dd
time: replace by `Range` iteration with `slice::Iter` in `Wheel`
paolobarbolini Apr 25, 2024
50a9245
time: improve fmt
paolobarbolini Apr 25, 2024
8d97f9b
time: cleanup how `MAX_SAFE_MILLIS_DURATION` is calculated
paolobarbolini Apr 25, 2024
49feda1
time: use `WakeList` in `Handle::process_at_time`
paolobarbolini Apr 25, 2024
c329e01
time: drop needless `get_unchecked_mut` in `TimerEntry::poll_elapsed`
paolobarbolini Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
time: use compare_exchange_weak in StateCell::mark_pending 
`StateCell::mark_pending` already uses a loop to retry the
compare exchange operation if it fails.

The logic within the loop would handle a spurious failure
like any other failure, so `compare_exchange_weak` makes
the implementation more efficient for some platforms.
  • Loading branch information
@paolobarbolini
paolobarbolini committed Apr 25, 2024
commit bda0d8f61b411b985140e98043cf153d2ee5a38b
2 changes: 1 addition & 1 deletion tokio/src/runtime/time/entry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ impl StateCell {
break Err(cur_state);
}

match self.state.compare_exchange(
match self.state.compare_exchange_weak(
cur_state,
STATE_PENDING_FIRE,
Ordering::AcqRel,
Expand Down