Fix obsolete reference to “stream ID” in ReadHalf::unsplit() documentation.
#6498
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mox692
added
T-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SplitStreamIds were added in 5bf78d7 and removed the next day in c7719a2, and never made it into a release. Therefore, the documentation forunsplit()mentioning “comparing the stream ID” is incorrect (and has been since its introduction in tokio 0.2.10).Solution
Describe the actual method for checking the precondition of
ReadHalf::unsplit(): callingReadHalf::is_pair_of().