Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(process): Use pidfd on Linux for tokio::process::Child::wait #6152

Merged
merged 17 commits into from
Jan 11, 2024
Merged

feature(process): Use pidfd on Linux for tokio::process::Child::wait #6152

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d3b6551
feat(process) pidfd: Implement initial `PidfdReaper` impl
NobodyXu Nov 13, 2023
106d9c8
Use `PidfdReaper` in `unix::Child` if possible
NobodyXu Nov 14, 2023
a3945d0
Fix compilation on non-linux targets
NobodyXu Nov 14, 2023
c6a869f
Add testing for `pidfd_reaper`
NobodyXu Nov 15, 2023
5f62be6
Fix running tests in `pidfd_reaper`
NobodyXu Nov 15, 2023
92bef5a
Disable `pidfd_reaper` test for miri
NobodyXu Nov 15, 2023
80a1cd7
Skip pidfd testing on unsupported linux kernel
NobodyXu Nov 15, 2023
c38faca
Optimization: Skip `pidfd_open` if last call failed with `ENOSYS`
NobodyXu Nov 15, 2023
3b89981
Fix `PidfdReaper::drop`: do not spawn any task there
NobodyXu Nov 27, 2023
bf14726
Only pull in `PidfdReaper` if feature rt is enabled on Linux
NobodyXu Jan 9, 2024
523117a
Add test `process_spawned_outside_runtime`
NobodyXu Jan 9, 2024
66a2f4e
Add `process_spawned_and_wait_in_different_runtime`
NobodyXu Jan 9, 2024
ef05617
Fix process_spawned_and_wait_in_different_runtime on linux with pidfd
NobodyXu Jan 10, 2024
e89a5ec
Improve safety comments in `Pidfd::open`
NobodyXu Jan 10, 2024
f093c44
Refactor `<PidfdReaperInner as Future>::poll`
NobodyXu Jan 10, 2024
7ee4509
Refactor: Mv `process_spawned_*` into `process_change_of_runtime.rs`
NobodyXu Jan 10, 2024
dc889e3
Fix leaked `sleep` process in `test_pidfd_reaper_drop`
NobodyXu Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix leaked sleep process in test_pidfd_reaper_drop 
Signed-off-by: Jiahao XU <[email protected]>
  • Loading branch information
@NobodyXu
NobodyXu committed Jan 11, 2024
commit dc889e36b428aa1c17682d185a386b87b3511e5c
8 changes: 6 additions & 2 deletions tokio/src/process/unix/pidfd_reaper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,11 +303,15 @@ mod test {

let queue = MockQueue::new();

let mut child = Command::new("sleep").arg("1800").spawn().unwrap();

run_test(async {
let child = Command::new("sleep").arg("1800").spawn().unwrap();
let _pidfd_reaper = PidfdReaper::new(child, &queue).unwrap();
let _pidfd_reaper = PidfdReaper::new(&mut child, &queue).unwrap();
});

assert_eq!(queue.all_enqueued.borrow().len(), 1);

child.kill().unwrap();
child.wait().unwrap();
}
}
Loading