Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joinset: fix loom test without tokio_unstable #4783

Merged
merged 1 commit into from
Jun 23, 2022
Merged

joinset: fix loom test without tokio_unstable #4783

merged 1 commit into from
Jun 23, 2022

Conversation

inevity
Copy link
Contributor

@inevity inevity commented Jun 22, 2022 •
edited
Loading

Motivation

LOOM_MAX_PREEMPTIONS=1 RUSTFLAGS="--cfg loom"  cargo test --lib --release --features full -- --test-threads=1 --nocapture

The command should be working without tokio_unstable RUSTFLAGS

Solution

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jun 22, 2022
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-task Module: tokio/task labels Jun 22, 2022
Darksonn
Darksonn approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 55078ff into tokio-rs:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inevity @Darksonn