Fix case where cancelled future would be leaked and add a regression … #3965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…test.
Fixes #3964
I have no idea if this is the correct fix as I don't really understand the design behind this code. EIther way, the comment here "The future has already been dropped" seems to be inaccurate.edit:
Updated based on feedback from @Darksonn - pretty sure this is the correct fix now.