Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio-io: make write_i* same behavior as write_all when poll_write re… #2334

Merged
merged 5 commits into from
Apr 12, 2020
Merged

tokio-io: make write_i* same behavior as write_all when poll_write re… #2334

merged 5 commits into from
Apr 12, 2020

Conversation

shuoli84
Copy link
Sponsor Contributor

…turns Ok(0)

Fixes: #2329

Motivation

Solution

carllerche
carllerche reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks. Would you mind adding a test so we avoid regressions in the future?

Thanks!

@shuoli84
Copy link
Sponsor Contributor Author

@carllerche sure, ut added.

Darksonn
Darksonn approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Darksonn Darksonn merged commit 060d22b into tokio-rs:master Apr 12, 2020
@Darksonn Darksonn mentioned this pull request Apr 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche left review comments

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When should poll_write return Error:ZeroWrite and when return Ok(0)
3 participants
@shuoli84 @carllerche @Darksonn