-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed list of Metrics to Stabilize #6546
Comments
Please see #6114, which renames some metrics. |
👍🏻 , it renames |
As a start, do you want to submit a PR that stabilizes just the overall metrics interface and |
…ilization This PR also introduces a `metrics` feature. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. This PR also introduces a `metrics` feature. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
We'd love to see this stabilized, especially these metrics that are the most important for us:
|
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
This PR stabilizes a single metric API to start the process of stabilizing metrics. Future work will continue to stabilize more metrics. Refs: tokio-rs#6546
As of today, the first metric has been stabilized in #6556. |
This stabilizes active_task_count. I also updated the metrics integration test to split unstable/vs. stable metrics so that we correctly test stable metrics in all cases. Refs: tokio-rs#6546
Is your feature request related to a problem? Please describe.
Given the impact, hassle, and perceived "risk" of compiling with
tokio_unstable
, I'd like to propose we stabilize some of the existing metrics.Describe the solution you'd like
Based on existing usage I've identified, propose the following metrics for stabilization. I've selected metrics that could plausibly include an actual alarm threshold.
Proposed Metrics for Stabilization
num_active_tasks
active_tasks_count: Used for ensuring that runtime is behaving as expected (e.g. no accidental spawn leakages). Suggested alarms: high-water mark, 0.high-water mark
Proposed longer term work:
injection_queue_metrics() -> QueueMetrics { ... }
for queues in the future.workers_overflow_count(&self) -> impl Iterator<Item=(usize, usize)>
tokio-runtime-monitor
crate that takes an opinionated stats of metrics to report and includes alarms. Perhaps this crate could publish directly tometrics.rs
? This crate would compile on stable Tokio.Appendix: All Metrics
Additional context
#4073
The text was updated successfully, but these errors were encountered: