Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tokio-rs/tokio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9f387cf
Choose a base ref
...
head repository: tokio-rs/tokio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b89981
Choose a head ref
  • 14 commits
  • 18 files changed
  • 5 contributors

Commits on Dec 28, 2023

  1. benches: fix benchmarking conflicts for real this time (#6246)

    @Darksonn
    Darksonn authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    52f28dc View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. ci: fix new warnings on 1.75.0 (#6255)

    @mox692
    mox692 authored Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5f7fe8f View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. io: make repeat and sink cooperative (#6254)

    @mox692
    mox692 authored Dec 30, 2023
    Configuration menu
    Copy the full SHA
    581cd41 View commit details
    Browse the repository at this point in the history

  2. net: add support for anonymous unix pipes (#6127)

    @satakuma
    satakuma authored Dec 30, 2023
    Configuration menu
    Copy the full SHA
    48345d6 View commit details
    Browse the repository at this point in the history

  3. sync: add watch::Receiver::mark_unchanged (#6252)

    @PaulOlteanu
    PaulOlteanu authored Dec 30, 2023
    Configuration menu
    Copy the full SHA
    02b779e View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. feat(process) pidfd: Implement initial PidfdReaper impl 

    Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    d3b6551 View commit details
    Browse the repository at this point in the history

  2. Use PidfdReaper in unix::Child if possible 

    fallback to signal-based `Reaper` if pidfd cannot be created.

Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    106d9c8 View commit details
    Browse the repository at this point in the history

  3. Fix compilation on non-linux targets 

    Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    a3945d0 View commit details
    Browse the repository at this point in the history

  4. Add testing for pidfd_reaper 

    Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    c6a869f View commit details
    Browse the repository at this point in the history

  5. Fix running tests in pidfd_reaper 

    Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    5f62be6 View commit details
    Browse the repository at this point in the history

  6. Disable pidfd_reaper test for miri 

    Since miri does not support process spawning

Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    92bef5a View commit details
    Browse the repository at this point in the history

  7. Skip pidfd testing on unsupported linux kernel 

    Only Linux kernel >= 5.10 support pidfd

Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    80a1cd7 View commit details
    Browse the repository at this point in the history

  8. Optimization: Skip pidfd_open if last call failed with ENOSYS 

    And fixed `test::is_pidfd_available`

Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    c38faca View commit details
    Browse the repository at this point in the history

  9. Fix PidfdReaper::drop: do not spawn any task there 

    To avoid potential headaches such as:

 - The drop being run outside of a Tokio runtime context
 - The runtime being present but not actually running

Since this is the initial implementation, I chose to use the
`OrphanQueue` also used by the signal-driven `Reaper` impl.

It's simple and easy to implement without having to add runtime driver
and guaranteed to work.

Further improvement can be done on the basis of this PR.

Signed-off-by: Jiahao XU <[email protected]>
    @NobodyXu
    NobodyXu committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    3b89981 View commit details
    Browse the repository at this point in the history
Loading