Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid shaking when renaming doc in title bar #6847

Merged
merged 1 commit into from
May 9, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented May 9, 2024

  • before
    CleanShot 2024-05-09 at 14.42.45.gif

  • after
    CleanShot 2024-05-09 at 14.43.57.gif

Copy link

graphite-app bot commented May 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice requested review from EYHN and pengx17 May 9, 2024 06:42
@CatsJuice CatsJuice marked this pull request as ready for review May 9, 2024 06:42
Copy link

nx-cloud bot commented May 9, 2024

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (291db7d) to head (960b906).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6847   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files         583      583           
  Lines       27148    27148           
  Branches     2526     2526           
=======================================
  Hits        18103    18103           
  Misses       8777     8777           
  Partials      268      268           
Flag Coverage Δ
server-test 77.25% <ø> (ø)
unittest 40.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 9, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/fix/title-renamiing-shaking branch from 8c1dd9c to 960b906 Compare May 9, 2024 07:15
@graphite-app graphite-app bot merged commit 960b906 into canary May 9, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/title-renamiing-shaking branch May 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants