Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): windows app controls missing #6832

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented May 8, 2024

fix #6825

Copy link

graphite-app bot commented May 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review May 8, 2024 06:48
Copy link
Member Author

EYHN commented May 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 8, 2024

@EYHN EYHN requested review from pengx17 and JimmFly May 8, 2024 06:49
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 40.28%. Comparing base (4a032eb) to head (e00c697).

Files Patch % Lines
...ore/src/modules/workbench/view/route-container.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6832      +/-   ##
==========================================
- Coverage   40.28%   40.28%   -0.01%     
==========================================
  Files         415      415              
  Lines        7754     7755       +1     
  Branches     1287     1288       +1     
==========================================
  Hits         3124     3124              
- Misses       4403     4404       +1     
  Partials      227      227              
Flag Coverage Δ
unittest 40.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 8, 2024

Merge activity

@graphite-app graphite-app bot merged commit e00c697 into canary May 8, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/windows branch May 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: No Buttons (Not Visible / Clickable) for Closing, Minimizing and Scaling the AFFiNE Client.​
3 participants