Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify experimental features to app-level #6823

Merged
merged 1 commit into from
May 8, 2024

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented May 7, 2024

TL;DR

Modify experimental features to be app-level settings items, no distinction between workspaces.

What changed?

  • Components moved from workspace-setting to general-setting
  • Added enableExperimentalFeature flag in runtimeConfig
  • Updated e2e tests
  • Updated i18n copywriting
截屏2024-05-07 19 32 00

How to test?

  1. Open setting modal
  2. Open experimental features panel
  3. Confirm experimental prompt
  4. Check the experimental settings

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@akumatus
Copy link
Member Author

akumatus commented May 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

@akumatus akumatus requested a review from EYHN May 7, 2024 11:30
@akumatus akumatus changed the title fix: modify Experimental features to be app-level settings items fix: Modify experimental features to be app-level settings items May 7, 2024
@akumatus akumatus marked this pull request as ready for review May 7, 2024 11:38
@akumatus akumatus requested a review from Brooooooklyn May 7, 2024 11:39
@akumatus akumatus changed the title fix: Modify experimental features to be app-level settings items fix: Modify experimental features to app-level May 7, 2024
@akumatus akumatus force-pushed the fix/experimental-feature-to-app-level branch from 50b6c78 to 2c55536 Compare May 8, 2024 02:41
Copy link

nx-cloud bot commented May 8, 2024

@akumatus akumatus force-pushed the fix/experimental-feature-to-app-level branch from 2c55536 to 8da61ed Compare May 8, 2024 02:42
@akumatus akumatus changed the title fix: Modify experimental features to app-level fix: modify experimental features to app-level May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (e85548b) to head (2736310).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6823      +/-   ##
==========================================
- Coverage   66.76%   66.69%   -0.08%     
==========================================
  Files         583      583              
  Lines       27143    27143              
  Branches     2524     2523       -1     
==========================================
- Hits        18122    18103      -19     
- Misses       8753     8772      +19     
  Partials      268      268              
Flag Coverage Δ
server-test 77.25% <ø> (-0.10%) ⬇️
unittest 40.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akumatus akumatus force-pushed the fix/experimental-feature-to-app-level branch from 8da61ed to 2736310 Compare May 8, 2024 03:42
@EYHN EYHN merged commit 4a032eb into canary May 8, 2024
36 checks passed
@EYHN EYHN deleted the fix/experimental-feature-to-app-level branch May 8, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants