Fix incorrect definition of IS_AMD on NVIDIA hardware #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x86games
approved these changes
Sep 13, 2018
|
Thanks! I was just about to push a fix, but seems you were faster :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely untested suggestion for fixing #103 by ignoring "ati" when it is in the middle of the string, since "ati" also occurs in the strings "NVIDIA Corporation", "Intel Corporation", "Microsoft Corporation" and "Imagination Technologies".
For reference, here is a list of vendor strings that are out there in the wild:
https://feedback.wildfiregames.com/report/opengl/feature/GL_VENDOR
Fixes #103