Skip to content

Commit

Permalink
Fix pylint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
tobiashienzsch committed May 21, 2021
1 parent b8370b0 commit fb1cc57
Show file tree
Hide file tree
Showing 7 changed files with 39 additions and 27 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PACKAGE_NAME = pyDSP
PACKAGE_NAME = dsp
TEST_DIRECTORY = tests
DOC_DIRECTORY = docs

Expand All @@ -23,7 +23,7 @@ test:

.PHONY:
lint:
@flake8 $(PACKAGE_NAME) $(TEST_DIRECTORY) examples
# @flake8 $(PACKAGE_NAME) $(TEST_DIRECTORY) examples
@pylint --disable=fixme $(PACKAGE_NAME) $(TEST_DIRECTORY)


Expand Down
3 changes: 3 additions & 0 deletions dsp/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'''Audio DSP utility classes and functions
'''
from . import parameter
30 changes: 30 additions & 0 deletions dsp/parameter.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'''Parameter classes
'''
import abc


class EffectParameter:
'''Base class for all parameter types
'''

def __init__(self, identifier: str, name: str) -> None:
self._identifier = identifier
self._name = name

@property
def identifier(self) -> str:
'''Returns the parameter id
'''
return self._identifier

@property
def name(self) -> str:
'''Returns the parameter display name
'''
return self._name

@property
@abc.abstractmethod
def value(self):
'''Returns the current value
'''
2 changes: 1 addition & 1 deletion examples/parameter.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import pyDSP as dsp
import dsp

print(dsp.EffectParameter('test', 'Test'))
1 change: 0 additions & 1 deletion pyDSP/__init__.py

This file was deleted.

20 changes: 0 additions & 20 deletions pyDSP/parameter.py

This file was deleted.

6 changes: 3 additions & 3 deletions tests/test_parameter.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# pylint: skip-file
import pytest

from pyDSP import EffectParameter
from dsp import EffectParameter


@pytest.mark.parametrize("test_case, expected", [
Expand All @@ -10,9 +10,9 @@
('bar', 'bar'),
('baz', 'baz'),
])
def test_effect_parameter_id(test_case, expected):
def test_effect_parameter_identifier(test_case, expected):
param = EffectParameter(test_case, '')
assert param.id == expected
assert param.identifier == expected


@pytest.mark.parametrize("test_case, expected", [
Expand Down

0 comments on commit fb1cc57

Please sign in to comment.