Apply clang-tidy fixes

src/Main.cpp

@@ -52,7 +52,7 @@ struct GuiAppApplication final : public juce::JUCEApplication
  */
 
  private:
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainWindow)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainWindow) // NOLINT
  };
 
 private:

src/MainComponent.hpp

@@ -30,5 +30,5 @@ struct MainComponent final : juce::Component
  ta::MainSection _jogWheel;
  ta::Display _display{_formatManager, _djPlayer};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainComponent)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainComponent) // NOLINT
 };

src/UI/Component/JogWheel.hpp

@@ -16,7 +16,7 @@ struct JogWheel final : juce::Component
  juce::String _text{};
  juce::Colour _background{};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(JogWheel)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(JogWheel) // NOLINT
 };
 
 } // namespace ta

src/UI/Component/Placeholder.hpp

@@ -16,7 +16,7 @@ struct Placeholder final : juce::Component
  juce::String _text{};
  juce::Colour _background{};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(Placeholder)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(Placeholder) // NOLINT
 };
 
 } // namespace ta

src/UI/Component/WaveformDisplay.hpp

@@ -25,6 +25,6 @@ struct WaveformDisplay final
  bool _fileLoaded{false};
  double _position{0};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(WaveformDisplay)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(WaveformDisplay) // NOLINT
 };
 } // namespace ta

src/UI/Section/Display.cpp

@@ -18,7 +18,7 @@ auto Display::resized() -> void { _waveformDisplay.setBounds(getLocalBounds());
 
 auto Display::timerCallback() -> void { _waveformDisplay.setPositionRelative(_djPlayer.positionRelative()); }
 
-auto Display::loadURL(juce::URL url) -> void { _waveformDisplay.loadURL(std::move(url)); }
+auto Display::loadURL(juce::URL const& url) -> void { _waveformDisplay.loadURL(url); }
 
 auto Display::djPlayerFileChanged(juce::File const& file) -> void { _waveformDisplay.loadURL(juce::URL{file}); }
 

src/UI/Section/Display.hpp

@@ -13,7 +13,7 @@ struct Display final
  Display(juce::AudioFormatManager& formatManager, DJPlayer& djPlayer);
  ~Display() override;
 
- auto loadURL(juce::URL url) -> void;
+ auto loadURL(juce::URL const& url) -> void;
 
  auto resized() -> void override;
  auto timerCallback() -> void override;
@@ -24,7 +24,7 @@ struct Display final
  juce::AudioThumbnailCache _thumbnailCache;
  WaveformDisplay _waveformDisplay;
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(Display)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(Display) // NOLINT
 };
 
 } // namespace ta

src/UI/Section/MainSection.hpp

@@ -14,7 +14,7 @@ struct MainSection final : juce::Component
 private:
  JogWheel _jogWheel{"Jogwheel", juce::Colours::green};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainSection)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MainSection) // NOLINT
 };
 
 } // namespace ta

src/UI/Section/SideBarLeft.hpp

@@ -20,7 +20,7 @@ struct SideBarLeft final : juce::Component
  juce::TextButton _cueButton{"Cue"};
  juce::TextButton _playButton{"Play"};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(SideBarLeft)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(SideBarLeft) // NOLINT
 };
 
 } // namespace ta

src/UI/Section/SideBarRight.hpp

@@ -24,7 +24,7 @@ struct SideBarRight final : juce::Component
  juce::ComboBox _tempoRange;
  juce::Slider _tempo{juce::Slider::LinearVertical, juce::Slider::TextBoxBelow};
 
- JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(SideBarRight)
+ JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(SideBarRight) // NOLINT
 };
 
 } // namespace ta