Fix a clang-tidy warning

tobanteAudio · Jun 13, 2022 · 486d569 · 486d569
1 parent c88a851
commit 486d569
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/DSP/AudioFile.hpp b/src/DSP/AudioFile.hpp
@@ -9,6 +9,9 @@ namespace ta
 template<typename ExpectedFormat>
 auto fileHasFormat(juce::AudioFormatManager& formatManager, juce::File const& file) -> bool
 {
+ static_assert(std::is_base_of<juce::AudioFormat, ExpectedFormat>::value,
+ "ExpectedFormat must be a subclass of AudioFormat");
+
  auto reader = std::unique_ptr<juce::AudioFormatReader>(formatManager.createReaderFor(file));
  if (reader == nullptr) { return false; }
  return dynamic_cast<ExpectedFormat*>(reader.get()) != nullptr;

diff --git a/src/DSP/AudioFileConverter.hpp b/src/DSP/AudioFileConverter.hpp
@@ -49,7 +49,8 @@ inline auto AudioFileConverter::convert(Options const& options) -> Result
  auto writer = std::unique_ptr<juce::AudioFormatWriter>(format.createWriterFor(out.get(), sr, ch, bits, {}, 0));
 
  if (writer == nullptr) { return Result{false, "Failed to convert to wav"}; }
- out.release(); // writer took ownership
+ auto* p = out.release(); // writer took ownership
+ (void)p; // fixes nodiscard warning on release
 
  writer->writeFromAudioReader(*reader, 0, reader->lengthInSamples);
  writer->flush();