Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Player not filling full height of screen #79

Closed
MrConqueror opened this issue Jul 19, 2023 · 6 comments
Closed

[Bug] Player not filling full height of screen #79

MrConqueror opened this issue Jul 19, 2023 · 6 comments
Labels

Comments

@MrConqueror
Copy link

is there a setting where to make the player look like this?
Screenshot_2023-07-19-14-38-44-642_com toasterofbread spmp

i prefer the player above to this one below.
Screenshot_2023-07-19-14-38-50-051_com toasterofbread spmp

@toasterofbread
Copy link
Owner

toasterofbread commented Jul 19, 2023

Weird, it's supposed to look like the first image (it does on my device).
What version of Android are you using? And are you using any mods like Magisk or Xposed modules which might modify the status bar or navigation bar height?

@toasterofbread toasterofbread changed the title Music Player [Bug] Player not filling full height of screen Jul 19, 2023
@danielphan2003
Copy link

There is also the case when the player disappear after a while but the FAB is still behind the status bar: Screenshot_20230719-194612.png

@toasterofbread
Copy link
Owner

What version of Android are you experiencing this on?

@danielphan2003
Copy link

What version of Android are you experiencing this on?

It's Android 13 (Pixys OS)

@toasterofbread
Copy link
Owner

I've found the cause of the bug. I was testing the app with my navigation bar hidden, so I never made the UI take the navbar height into account. I'll get a fix out soon.

@toasterofbread
Copy link
Owner

toasterofbread commented Jul 21, 2023

Should be fixed now. I've tested fairly thoroughly with each navbar type, but let me know if anything still looks weird.
You can test the changes when the build action completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants