Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font style #69

Closed
youtubedoc opened this issue Jul 16, 2023 · 2 comments
Closed

Font style #69

youtubedoc opened this issue Jul 16, 2023 · 2 comments
Labels
Planned

Comments

@youtubedoc
Copy link

youtubedoc commented Jul 16, 2023 •
edited
Loading

Most of the things are working fine so far, thank you for that! If you can please add an option to change the application font, that would be great!
@toasterofbread
Copy link
Owner

toasterofbread commented Jul 16, 2023 •
edited
Loading

I'd love to add an option for the font at some point, but I've had issues with lyrics displaying incorrectly with some fonts (which is why the default English font isn't the nicest).
At some point I'll figure out what's wrong and find a better default font, and add an option for changing it. Thanks for the suggestion!

@toasterofbread
Copy link
Owner

I've fixed the issue with the lyrics I mentioned added an option to set the app font to default, system, or a specific font. The current font (HC Maru Gothic) will only be applied by default when the UI language is Japanese, so otherwise the default font is the system font.

I haven't added any extra fonts (yet) but I'm open to suggestions.

toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Add font option, fix non-standard font lyrics
3394564 
Rewrite lyrics display to fix incorrect display with some fonts
Make top bar and main view lyrics display style consistent
Reduce space between main lyrics text and furigana
Fix lack of padding below settings subpages
Add font selection option (closes #69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toasterofbread @youtubedoc