Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlists #51

Closed
9 of 11 tasks
Tracked by #47
toasterofbread opened this issue May 15, 2023 · 0 comments
Closed
9 of 11 tasks
Tracked by #47

Playlists #51

toasterofbread opened this issue May 15, 2023 · 0 comments
Labels
Planned

Comments

@toasterofbread
Copy link
Owner

toasterofbread commented May 15, 2023 •
edited

  • Local playlists
  • YouTube account playlists
  • Add / remove / move songs
  • Set title and description
  • Set thumbnail (probably local-only?)
  • Set visibility (account only)
  • Multiselect support
  • Add / remove songs to a playlist from any long press menu context
  • Show playlists in a library page
  • Create from song long press menu
  • Create from library page button
@toasterofbread toasterofbread mentioned this issue May 15, 2023
Closed
16 tasks
@toasterofbread toasterofbread changed the title Create playlist Playlist creation May 15, 2023
@toasterofbread toasterofbread added this to the 1.0 milestone May 15, 2023
@toasterofbread toasterofbread changed the title Playlist creation Playlists May 22, 2023
toasterofbread added a commit that referenced this issue May 25, 2023
@toasterofbread
Hide MainPage artists row when empty
333cb1b 
Option to close NPM on action
Option to increment play after index on add
Continue LocalPlaylist, begin playlist page reordering #51
Make NP queue undo button long press redo, rather than undoing all actions
Show PrefsPage reset button in landing page (action not implemented)
Move PrefsPage YTM account status item from general to the landing page
Remove multiselect toggle button from long press menu
toasterofbread added a commit that referenced this issue May 28, 2023
@toasterofbread
Continue local playlists and library page #51 #53
d489d59 
Move MediaItem data serialisation and loading into data classes
Add playlist delete action to multiselect bar
toasterofbread added a commit that referenced this issue May 28, 2023
@toasterofbread
Continue playlist page #51
6800a64 
Add remove button to PlaylistPage multiselect bar
Add LocalPlaylist MediaItemType
Use generic icon and accent colour for default playlist image, add image reset button
toasterofbread added a commit that referenced this issue May 29, 2023
@toasterofbread
Implement AccountPlaylist
3d2f9af 
Implement account playlist creation, deletion, fetching, etc. #51
Make MediaItemWithLayouts an interface

TODO:
Refactor MediaItemWithLayouts structure and usage
Replace uploaded local playlist with AccountPlaylist
toasterofbread added a commit that referenced this issue May 30, 2023
@toasterofbread
Mostly complete account playlists #51
78fac9e 
Add MediaItemHolder interface for handling playlist deletion and replacement
Send Youtubei error responses as toasts when reported to ErrorManager

Playlists:
- Implement deletion and replacement using MediaItemHolder
- Fix account playlist item movement saving
- Fix thumbnail not showing after local playlist upload
- Remove reorder detection from items
toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Hide MainPage artists row when empty
081e31c 
Option to close NPM on action
Option to increment play after index on add
Continue LocalPlaylist, begin playlist page reordering #51
Make NP queue undo button long press redo, rather than undoing all actions
Show PrefsPage reset button in landing page (action not implemented)
Move PrefsPage YTM account status item from general to the landing page
Remove multiselect toggle button from long press menu
toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Continue local playlists and library page #51 #53
26c263b 
Move MediaItem data serialisation and loading into data classes
Add playlist delete action to multiselect bar
toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Continue playlist page #51
3abc6a7 
Add remove button to PlaylistPage multiselect bar
Add LocalPlaylist MediaItemType
Use generic icon and accent colour for default playlist image, add image reset button
toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Implement AccountPlaylist
68ffec7 
Implement account playlist creation, deletion, fetching, etc. #51
Make MediaItemWithLayouts an interface

TODO:
Refactor MediaItemWithLayouts structure and usage
Replace uploaded local playlist with AccountPlaylist
toasterofbread added a commit that referenced this issue Nov 12, 2023
@toasterofbread
Mostly complete account playlists #51
1ce9ac8 
Add MediaItemHolder interface for handling playlist deletion and replacement
Send Youtubei error responses as toasts when reported to ErrorManager

Playlists:
- Implement deletion and replacement using MediaItemHolder
- Fix account playlist item movement saving
- Fix thumbnail not showing after local playlist upload
- Remove reorder detection from items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toasterofbread