New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics #28

Closed

5 tasks done

toasterofbread opened this issue Jan 16, 2023 · 0 comments

Labels

Owner

toasterofbread commented Jan 16, 2023 •

edited

Loading

Fix random(?) lyrics fetch fail
Tweak loading bar size
Re-implement timed lyrics highlighting for performance
Font size adjustment
Latency adjustment
~~Add long-press function to overlay menu button~~
~~Show top bar lyrics on all/most pages~~ Show top bar lyrics on all pages #56

toasterofbread changed the title ~~Lyrics display~~ Lyrics

toasterofbread added this to the 帰 milestone

toasterofbread added the Planned label

toasterofbread modified the milestones: 帰, 1.0

toasterofbread added a commit that referenced this issue


Fix slow lyrics, prepare to add lyrics sync menu #28

c411cac

Show feed filters while loading
Simplify LongFuriganaText, move into LyricsOverlayMenu, and remove unneeded code
Use unified lyrics sync offset for main lyrics and top bar lyrics
Prepare to implement lyrics sync menu

toasterofbread added a commit that referenced this issue


Lyrics sync progress (remote)

e432e3b

Disable lyrics autoscroll during sync line selection
Fix MediaItemGrid view more button not showing
Implement lyrics sync menu functionality #28
Misc bug fixes #36

toasterofbread closed this as completed in

5c77407

toasterofbread added a commit that referenced this issue


Fix slow lyrics, prepare to add lyrics sync menu #28

3befa2c

Show feed filters while loading
Simplify LongFuriganaText, move into LyricsOverlayMenu, and remove unneeded code
Use unified lyrics sync offset for main lyrics and top bar lyrics
Prepare to implement lyrics sync menu

toasterofbread added a commit that referenced this issue


Lyrics sync progress (remote)

2d629cc

Disable lyrics autoscroll during sync line selection
Fix MediaItemGrid view more button not showing
Implement lyrics sync menu functionality #28
Misc bug fixes #36

toasterofbread added a commit that referenced this issue


Various fixes and TODOs (remote)

44f82e7

Add alt style for MediaItemGrid (#7)
Fix false onCreate() call on MediaPlayerService
Show time until/since song plays in long press menu (#8)
Add long press to NowPlayingMainTab artist button (closes #8)
Remove PlatformContext.mainThread and PlatformContext.networkThread
Add prefs item for Settings.KEY_LYRICS_ENABLE_WORD_SYNC
Add Settings.KEY_LYRICS_FONT_SIZE (closes #28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment