Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to reduce the size of the player? #129

Closed
dainvincible1 opened this issue Aug 21, 2023 · 12 comments
Closed

Is there any way to reduce the size of the player? #129

dainvincible1 opened this issue Aug 21, 2023 · 12 comments
Labels

Comments

@dainvincible1
Copy link

image

@toasterofbread
Copy link
Owner

What version of Android are you using?

@dainvincible1
Copy link
Author

What version of Android are you using?

@toasterofbread android 10

@toasterofbread
Copy link
Owner

toasterofbread commented Aug 25, 2023

Strange, I'm not able to reproduce this. What type of system navigation (like gesture navigation or 3-button) are you using, and are using any mods (like Magisk modules) that change the appearance of the navigation bar? I don't see the navigation bar in the screenshot, is that what it actually looks like on your screen or is it just hidden in the screenshot?

@dainvincible1
Copy link
Author

Strange, I'm not able to reproduce this. What type of system navigation (like gesture navigation or 3-button) are you using, and are using any mods (like Magisk modules) that change the appearance of the navigation bar? I don't see the navigation bar in the screenshot, is that what it actually looks like on your screen or is it just hidden in the screenshot?

my phone is not rooted, so no magisk module.
and im using "swipe up gestures"
image

i tried to use the app in a phone with 3 button navigation, even in that the player size is like that

@toasterofbread
Copy link
Owner

0c4b35d should have fixed or at least improved this issue. It would be great if you could test it and report any differences.

@dainvincible1
Copy link
Author

0c4b35d should have fixed or at least improved this issue. It would be great if you could test it and report any differences.

@toasterofbread sorry for late reply but the issue is still there. maybe its something due to the phone, when i tried the app in a tablet then this issue was not there
Screenshot_2023-09-20-22-48-31-71_7494cfb0f4df78e8ea8a89ba4b755132

@toasterofbread
Copy link
Owner

Are you using the commit I mentioned? If not, try with the latest build from the repo actions (I don't think anything's changed but you never know).

If that doesn't work then go to the in-app settings, developer, UI debug info, screenshot that page and upload it here please.

@dainvincible1
Copy link
Author

Screenshot_2023-09-22-10-14-45-67_7494cfb0f4df78e8ea8a89ba4b755132
@toasterofbread here it is

@toasterofbread
Copy link
Owner

Looks like your OS is providing the wrong height for the navigation bar which from what I can tell is hidden, am I right?
I'll add an option to adjust/remove the navigation bar height for cases like these.

@dainvincible1
Copy link
Author

Looks like your OS is providing the wrong height for the navigation bar which from what I can tell is hidden, am I right? I'll add an option to adjust/remove the navigation bar height for cases like these.

yes, its hidden. thank you so much that'll be awesome.

@toasterofbread
Copy link
Owner

I've added a slider that can be used to adjust the system-reported navigation bar height, set it to zero and it should hopefully look fine. It's at the top of the 'Other' section.

@dainvincible1
Copy link
Author

I've added a slider that can be used to adjust the system-reported navigation bar height, set it to zero and it should hopefully look fine. It's at the top of the 'Other' section.

yes, it has been fixed, thank you very much
Screenshot_2023-09-23-20-18-57-36_e82a23cb50dd4a2f2e01332c4ab3b632

toasterofbread added a commit that referenced this issue Nov 12, 2023
Index Disord status images using an external database, as reading directly from Discord was too slow
Add navigation bar height multiplier setting (closes #129)
Add MUTE_PLAYER debug key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants