New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Lyrics longer than the top bar length, isn't shows properly and is cut off. #122

Closed

zerobun opened this issue Aug 21, 2023 · 0 comments

Labels

zerobun commented Aug 21, 2023 •

edited

Describe the bug

It's not really a bug, but it's a visual problem. At the top bar when you use the lyrics option to see the lyrics lines, and if the lines a bit longer than the length of thr space the words go at the bottom and they are half cut. So u can't see it properly and it doesn't look good.

Steps To Reproduce

Tap the top visual bar
Choose lyrics option
Play a song such as "after thought" and by joji
At 3 seconds of the song "I've been slipping away from you" you see the problem

Expected behaviour

If the lyrics line is too long for thr allocated space I expected it to carry on under it but not cut off in the middle jus shown properly.

Environment

vivo y11 android 11
SpMp version 0.1. 4
Accounts (were you signed in to YouTube, Discord, etc. in the app?):
only signed into YouTube music.

Screenshots

In the home screen and the player screen, it's the same

Logs

zerobun added the Bug label

zerobun changed the title ~~[Bug]~~ [Bug] Lyrics longer than the top bar length, isn't shows properly and is cut off.

toasterofbread added a commit that referenced this issue


Fix NP gradient, LPM info, begin #122

6decdef

Fix incorrect NP gradient placement on overscroll
Fix LPM info button not appearing in some cases
Begin fixing #122 (WIP)

toasterofbread closed this as completed in

21f8a06

toasterofbread added a commit that referenced this issue


Fix NP gradient, LPM info, begin #122

f4ea234

Fix incorrect NP gradient placement on overscroll
Fix LPM info button not appearing in some cases
Begin fixing #122 (WIP)

toasterofbread added a commit that referenced this issue


Fix #122, add mini player prev button option

bf92f5c

Fix #122 (adds option for max top bar lyrics lines)
Add option to toggle prev button in minimised player

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment