Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Crash while main page was loading #114

Closed
opusforlife2 opened this issue Aug 18, 2023 · 4 comments
Closed

[Bug] Crash while main page was loading #114

opusforlife2 opened this issue Aug 18, 2023 · 4 comments
Labels

Comments

@opusforlife2
Copy link
Contributor

Describe the bug

Opened the app and the feed was loading. The crash occurred without any user input. The UI stopped responding to taps until the app was removed from Recents and then reopened.

Environment

  • Android 13
  • SpMp version: v0.1.4

Logs

Your error page is really nice, BTW. Clean and easy to use.

kotlin.NotImplementedError: MUSIC_PAGE_TYPE_ARTIST_DISCOGRAPHY
	at com.toasterofbread.spmp.model.mediaitem.MediaItem$Companion.fromBrowseEndpointType(Unknown Source:88)
	at com.toasterofbread.spmp.api.BrowseEndpoint.getMediaItem(Unknown Source:10)
	at com.toasterofbread.spmp.api.BrowseEndpoint.getViewMore(Unknown Source:2)
	at com.toasterofbread.spmp.api.NavigationEndpoint.getViewMore(Unknown Source:4)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$processDefaultResponse$2.invokeSuspend(Unknown Source:1194)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$processDefaultResponse$2.invoke(Unknown Source:8)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$processDefaultResponse$2.invoke(Unknown Source:4)
	at androidx.core.R$dimen.startUndispatchedOrReturn(Unknown Source:4)
	at coil.util.-Contexts.withContext(Unknown Source:71)
	at com.toasterofbread.spmp.api.LoadMediaitemKt.processDefaultResponse(Unknown Source:13)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$loadMediaItemData$2.invokeSuspend(Unknown Source:241)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$loadMediaItemData$2.invoke(Unknown Source:8)
	at com.toasterofbread.spmp.api.LoadMediaitemKt$loadMediaItemData$2.invoke(Unknown Source:4)
	at androidx.core.R$dimen.startUndispatchedOrReturn(Unknown Source:4)
	at coil.util.-Contexts.withContext(Unknown Source:71)
	at com.toasterofbread.spmp.api.LoadMediaitemKt.loadMediaItemData(Unknown Source:76)
	at com.toasterofbread.spmp.model.mediaitem.MediaItem$loadGeneralData$2.invokeSuspend(Unknown Source:121)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:100)
	at kotlinx.coroutines.internal.LimitedDispatcher.run(Unknown Source:12)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Unknown Source:2)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(Unknown Source:79)
	Suppressed: coil.network.HttpException: [androidx.compose.ui.platform.MotionDurationScaleImpl@ff90c68, androidx.compose.runtime.BroadcastFrameClock@f422881, StandaloneCoroutine{Cancelling}@c48bd26, AndroidUiDispatcher@5fe4d67]
@opusforlife2
Copy link
Contributor Author

BTW, it would be nice of you to credit Newpipe Extractor in your ReadMe along with the other projects. 👀

@toasterofbread
Copy link
Owner

BTW, it would be nice of you to credit Newpipe Extractor in your ReadMe along with the other projects. 👀

Good idea, not sure why I'm not doing this already.

@opusforlife2
Copy link
Contributor Author

Whoa. Thanks for the rapid fix!

@toasterofbread
Copy link
Owner

BTW, it would be nice of you to credit Newpipe Extractor in your ReadMe along with the other projects. 👀

Added!

@toasterofbread toasterofbread mentioned this issue Sep 9, 2023
toasterofbread added a commit that referenced this issue Nov 12, 2023
Centralise browse endpoint page type matching to MediaItemType.fromBrowseEndpointType (fixes #114)
Add pull refresh to artist page #88
Fix albums not loading
Add loading indicator and error display to artist page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants