Add tvm-bot lambda #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
force-pushed
the
tvmbot
branch
10 times, most recently
from
3b00626
to
0c54c1e
Compare
driazati
force-pushed
the
tvmbot
branch
11 times, most recently
from
8f52f0f
to
ada140b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the tvm-bot pr commenting logic from apache/tvm to an AWS Lambda function. This keeps it out of the queue and also gives us better guarantees about runtime (PR comments previously would take up to a minute to show up, with this they are pretty much instant), and this doesn't show up in the CI jobs box on PRs.
There is lots of copy paste from
tvm/ci/scriptsintotvm_bot/tvm_botwith some minor changes to work with lambda. The main infra changes are in the folder atop that inci/terraform, which adds a lambda function with an API gateway that exposes a URL that GitHub can send webhooks to.This PR is just a start so it skips the more complicated parts that generate PR-specific bits, like the docs URL and the skipped tests list. The commenting is also still gated to members of the OSS team.