Skip to content

Commit

Permalink
Use string:length instead of length for string lengths
Browse files Browse the repository at this point in the history
Better to always do this just in case we ever get any
unicode characters in there.
  • Loading branch information
garazdawi committed Apr 5, 2021
1 parent 255f10b commit e6e7c10
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions apps/els_lsp/src/els_rename_provider.erl
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,16 @@ workspace_edits(_Uri, _POIs, _NewName) ->
-spec editable_range(poi()) -> range().
editable_range(#{kind := callback, range := Range}) ->
#{ from := {FromL, FromC} } = Range,
EditFromC = FromC + length("-callback "),
EditFromC = FromC + string:length("-callback "),
els_protocol:range(Range#{ from := {FromL, EditFromC } });
editable_range(#{kind := export_entry, id := {F, _A}, range := Range}) ->
#{ from := {FromL, FromC} } = Range,
EditToC = FromC + length(atom_to_string(F)),
EditToC = FromC + string:length(atom_to_string(F)),
els_protocol:range(Range#{ to := {FromL, EditToC} });
editable_range(#{kind := spec, id := {F, _A}, range := Range}) ->
#{ from := {FromL, FromC}, to := {_ToL, _ToC} } = Range,
EditFromC = FromC + length("-spec "),
EditToC = EditFromC + length(atom_to_string(F)),
EditFromC = FromC + string:length("-spec "),
EditToC = EditFromC + string:length(atom_to_string(F)),
els_protocol:range(Range#{ from := {FromL, EditFromC}
, to := {FromL, EditToC} });
editable_range(#{kind := implicit_fun, id := {M, F, _A}, range := Range}) ->
Expand Down Expand Up @@ -138,7 +138,7 @@ editable_range(#{kind := _Kind, range := Range}) ->
-spec editable_range(poi_kind(), els_dt_references:item()) -> range().
editable_range(macro, #{range := Range}) ->
#{ from := {FromL, FromC} } = Range,
EditFromC = FromC + length("?"),
EditFromC = FromC + string:length("?"),
els_protocol:range(Range#{ from := {FromL, EditFromC} }).

-spec changes(uri(), poi(), binary()) -> #{uri() => [text_edit()]} | null.
Expand Down

0 comments on commit e6e7c10

Please sign in to comment.