Fix infinite loop when parsing macro in wild attribute name

Fixes erlang-ls#919
tks2103 · Feb 19, 2021 · be34322 · be34322
1 parent df50bd4
commit be34322
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/apps/els_lsp/src/els_parser.erl b/apps/els_lsp/src/els_parser.erl
@@ -637,7 +637,7 @@ attribute_name_atom(Tree) ->
  atom ->
  erl_syntax:atom_value(NameNode);
  _ ->
- Tree
+ NameNode
  end.
 
 -spec attribute_subtrees(atom() | tree(), [tree()]) -> [[tree()]].

diff --git a/apps/els_lsp/test/els_parser_SUITE.erl b/apps/els_lsp/test/els_parser_SUITE.erl
@@ -24,6 +24,7 @@
  , spec_macro/1
  , type_macro/1
  , opaque_macro/1
+ , wild_attrbibute_macro/1
  ]).
 
 %%==============================================================================
@@ -206,6 +207,13 @@ opaque_macro(_Config) ->
  ?assertMatch([_], parse_find_pois(Text, macro, 'M')),
  ok.
 
+-spec wild_attrbibute_macro(config()) -> ok.
+wild_attrbibute_macro(_Config) ->
+ Text = "-?M(foo).",
+ ?assertMatch([_], parse_find_pois(Text, macro, 'M')),
+ ?assertMatch([_], parse_find_pois(Text, atom, foo)),
+ ok.
+
 %%==============================================================================
 %% Helper functions
 %%==============================================================================