Support renaming function when standing on spec (erlang-ls#1190)

tks2103 · Feb 4, 2022 · 3e9902a · 3e9902a
1 parent 3e7ef67
commit 3e9902a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/apps/els_lsp/src/els_rename_provider.erl b/apps/els_lsp/src/els_rename_provider.erl
@@ -49,6 +49,8 @@ workspace_edits(_Uri, [], _NewName) ->
 workspace_edits(Uri, [#{kind := function_clause} = POI| _], NewName) ->
  #{id := {F, A, _}} = POI,
  #{changes => changes(Uri, POI#{kind => function, id => {F, A}}, NewName)};
+workspace_edits(Uri, [#{kind := spec} = POI| _], NewName) ->
+ #{changes => changes(Uri, POI#{kind => function}, NewName)};
 workspace_edits(Uri, [#{kind := Kind} = POI| _], NewName)
  when Kind =:= define;
  Kind =:= record;

diff --git a/apps/els_lsp/test/els_rename_SUITE.erl b/apps/els_lsp/test/els_rename_SUITE.erl
@@ -237,6 +237,8 @@ rename_function(Config) ->
  #{result := Result} = els_client:document_rename(Uri, 1, 9, NewName),
  %% Import entry
  #{result := Result} = els_client:document_rename(ImportUri, 2, 26, NewName),
+ %% Spec
+ #{result := Result} = els_client:document_rename(Uri, 3, 2, NewName),
  Expected = #{changes =>
  #{binary_to_atom(Uri, utf8) =>
  [ change(NewName, {12, 23}, {12, 26})