Only run EDoc diagnostics on .erl files (erlang-ls#1242)

apps/els_lsp/priv/code_navigation/src/code_navigation.app.src

@@ -0,0 +1,14 @@
+{application, code_navigation, [
+ {description, "Erlang LS - Test App"},
+ {vsn, git},
+ {registered, []},
+ {applications, [
+ kernel,
+ stdlib
+ ]},
+ {env, []},
+ {modules, []},
+ {maintainers, []},
+ {licenses, ["Apache 2.0"]},
+ {links, []}
+]}.

apps/els_lsp/src/els_edoc_diagnostics.erl

@@ -41,6 +41,15 @@ is_default() ->
 %% warnings and errors.
 -spec run(uri()) -> [els_diagnostics:diagnostic()].
 run(Uri) ->
+ case filename:extension(Uri) of
+ <<".erl">> ->
+ do_run(Uri);
+ _ ->
+ []
+ end.
+
+-spec do_run(uri()) -> [els_diagnostics:diagnostic()].
+do_run(Uri) ->
  Paths = [els_utils:to_list(els_uri:path(Uri))],
  Fun = fun(Dir) ->
  Options = edoc_options(Dir),

apps/els_lsp/test/els_diagnostics_SUITE.erl

@@ -44,6 +44,7 @@
  , module_name_check/1
  , module_name_check_whitespace/1
  , edoc_main/1
+ , edoc_skip_app_src/1
  ]).
 
 %%==============================================================================
@@ -126,7 +127,8 @@ init_per_testcase(TestCase, Config) when TestCase =:= gradualizer ->
  meck:expect(els_gradualizer_diagnostics, is_default, 0, true),
  els_mock_diagnostics:setup(),
  els_test_utils:init_per_testcase(TestCase, Config);
-init_per_testcase(TestCase, Config) when TestCase =:= edoc_main ->
+init_per_testcase(TestCase, Config) when TestCase =:= edoc_main;
+ TestCase =:= edoc_skip_app_src ->
  meck:new(els_edoc_diagnostics, [passthrough, no_link]),
  meck:expect(els_edoc_diagnostics, is_default, 0, true),
  els_mock_diagnostics:setup(),
@@ -172,7 +174,8 @@ end_per_testcase(TestCase, Config) when TestCase =:= gradualizer ->
  els_test_utils:end_per_testcase(TestCase, Config),
  els_mock_diagnostics:teardown(),
  ok;
-end_per_testcase(TestCase, Config) when TestCase =:= edoc_main ->
+end_per_testcase(TestCase, Config) when TestCase =:= edoc_main;
+ TestCase =:= edoc_skip_app_src ->
  meck:unload(els_edoc_diagnostics),
  els_test_utils:end_per_testcase(TestCase, Config),
  els_mock_diagnostics:teardown(),
@@ -716,6 +719,15 @@ edoc_main(_Config) ->
  Hints = [],
  els_test:run_diagnostics_test(Path, Source, Errors, Warnings, Hints).
 
+ -spec edoc_skip_app_src(config()) -> ok.
+edoc_skip_app_src(_Config) ->
+ Path = src_path("code_navigation.app.src"),
+ Source = <<"Edoc">>,
+ Errors = [],
+ Warnings = [],
+ Hints = [],
+ els_test:run_diagnostics_test(Path, Source, Errors, Warnings, Hints).
+
 %%==============================================================================
 %% Internal Functions
 %%==============================================================================