fix for writedlm with empty columns

tknopp · Mar 26, 2014 · eaef4a1 · eaef4a1
1 parent e6e3c39
commit eaef4a1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/base/datafmt.jl b/base/datafmt.jl
@@ -304,7 +304,7 @@ readcsv(io, T::Type; opts...) = readdlm(io, ',', T; opts...)
 # todo: keyword argument for # of digits to print
 writedlm_cell(io::IO, elt::FloatingPoint, dlm) = print_shortest(io, elt)
 function writedlm_cell{T}(io::IO, elt::String, dlm::T)
- if ('"' == elt[1]) || ('\n' in elt) || ((T <: Char) ? (dlm in elt) : contains(elt, dlm))
+ if !isempty(elt) && (('"' == elt[1]) || ('\n' in elt) || ((T <: Char) ? (dlm in elt) : contains(elt, dlm)))
  print(io, '"', replace(elt, r"\"", "\"\""), '"')
  else
  print(io, elt)

diff --git a/test/readdlm.jl b/test/readdlm.jl
@@ -66,6 +66,12 @@ let x = ["abc", "def\"ghi", "jk\nl"], y = [1, ",", "\"quoted\""], io = IOBuffer(
  @test readcsv(io) == [x y]
 end
 
+let x = ["a" "b"; "d" ""], io = IOBuffer()
+ writedlm(io, x)
+ seek(io, 0)
+ @test readdlm(io) == x
+end
+
 
 # source: https://www.i18nguy.com/unicode/unicode-example-utf8.zip
 let i18n_data = ["Origin (English)", "Name (English)", "Origin (Native)", "Name (Native)",