Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): invalid UTF-8 in text frame #316

Merged
merged 2 commits into from
Apr 29, 2020
Merged

fix(gateway): invalid UTF-8 in text frame #316

merged 2 commits into from
Apr 29, 2020

Conversation

choujimmy
Copy link
Contributor

There are two problems in the original webtty function:

  • The server uses a separate goroutine to send and read data from the websocket connection. When the client quickly enters stdin, multiple outputs from stdout will be truncated;
  • The data transmission between the client and the server is not coded, and special characters will produce Invalid UTF-8 in text frame errors

@choujimmy choujimmy requested a review from Yacent as a code owner April 29, 2020 07:03
@choujimmy choujimmy merged commit fc83128 into master Apr 29, 2020
@choujimmy choujimmy deleted the fix_webtty_vim branch April 29, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant