Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(health check): check cluster status for multiple times in health check go get rid of socket connection failure #2310 #2311

Merged

Conversation

pikehuang
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug

What this PR does / why we need it:
fix bug #2310
simple description:
cluster health check will failed in most case bacause the socket connection to the target cluster is not stable, so we check multiple times when for cluster health check.

Which issue(s) this PR fixes:

Fixes #2310

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@leoryu
Copy link
Contributor

leoryu commented Oct 25, 2023

LGTM

Copy link
Collaborator

@GaoXiaodong GaoXiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pikehuang pikehuang changed the title fix bug 2310 fix(health check): check cluster status for multiple times in health check go get rid of socket connection failure #2310 Oct 25, 2023
@pikehuang pikehuang force-pushed the feature/enhance-cluster-healchcheck-20231024 branch 2 times, most recently from 5d90a2c to 622f85f Compare October 25, 2023 07:27
in health check to go get rid of socket connection failure tkestack#2310
@pikehuang pikehuang force-pushed the feature/enhance-cluster-healchcheck-20231024 branch from 622f85f to 9731331 Compare October 25, 2023 07:29
@leoryu leoryu merged commit b7900fc into tkestack:master Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants