Feature/variable interpolation #45
Conversation
|
@yields maybe you want to have a look at it. I extracted all of the interpolation relevant stuff into a new |
interpolation/interpolation.go
Outdated
|
|
||
| // captureCommandOutput executes a command and captures the output which usually gets prompted to stdout. | ||
| func captureCommandOutput(args string) (string, error) { | ||
| cmd := exec.Command("sh", "-c", args) |
There was a problem hiding this comment.
Should we default to the user's active shell?
There was a problem hiding this comment.
I used $SHELL to find a user's active shell and as a fallback it will be still sh. Might do the trick, what do you think?
|
I made a separate commit with the work due to review findings but I will squash them into the previous one(s) as soon as you're happy with it so we have a clean history :-) |
…olation. A variable in the variables section can now reference another variable and will get populated before an actual task’s content will get populated. Additionally to self-referencing variables `$()` will run a command and capture the output into a variable.
…he variables section on the root level and on levels higher than level two.
jenpet
force-pushed
the
feature/variable_interpolation
branch
from
2072015
to
eb1f1bb
Compare
|
Sweet :-). I'm done so far. I got more ideas which might be useful. I'd just open a ticket for them at some point in time and create pull requests if you guys are happy with the approaches. Thanks for releasing! |
Addressing discussed issue #44 and a bug which did not allow to prompt variables when there is a variable on root level or on levels higher than two.