remove constructor helper

tixl · May 21, 2021 · 92c052e · 92c052e
1 parent 72b250b
commit 92c052e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/src/entities/fractions/currencyAmount.test.ts b/src/entities/fractions/currencyAmount.test.ts
@@ -26,7 +26,7 @@ describe('CurrencyAmount', () => {
 
   describe('#ether', () => {
     it('produces ether amount', () => {
-      const amount = CurrencyAmount.ether(1, 100)
+      const amount = CurrencyAmount.fromRawAmount(Ether.onChain(1), 100)
       expect(amount.quotient).toEqual(JSBI.BigInt(100))
       expect(amount.currency).toEqual(Ether.onChain(1))
     })

diff --git a/src/entities/fractions/currencyAmount.ts b/src/entities/fractions/currencyAmount.ts
@@ -1,8 +1,6 @@
 import invariant from 'tiny-invariant'
 import JSBI from 'jsbi'
 import { Currency } from '../currency'
-import { Ether } from '../ether'
-import { NativeCurrency } from '../nativeCurrency'
 import { Token } from '../token'
 import { Fraction } from './fraction'
 import _Big from 'big.js'
@@ -17,7 +15,7 @@ export class CurrencyAmount<T extends Currency> extends Fraction {
   public readonly decimalScale: JSBI
 
   /**
-   * Returns a new currency amount instance from the
+   * Returns a new currency amount instance from the unitless amount of token, i.e. the raw amount
    * @param currency the currency in the amount
    * @param rawAmount the raw token or ether amount
    */
@@ -39,15 +37,6 @@ export class CurrencyAmount<T extends Currency> extends Fraction {
     return new CurrencyAmount(currency, numerator, denominator)
   }
 
-  /**
-   * Helper that calls the constructor with the Ether currency
-   * @param chainId the chain on which the ether exists
-   * @param rawAmount ether amount in wei
-   */
-  public static ether(chainId: number, rawAmount: BigintIsh): CurrencyAmount<NativeCurrency> {
-    return CurrencyAmount.fromRawAmount(Ether.onChain(chainId), rawAmount)
-  }
-
   protected constructor(currency: T, numerator: BigintIsh, denominator?: BigintIsh) {
     super(numerator, denominator)
     invariant(JSBI.lessThanOrEqual(this.quotient, MaxUint256), 'AMOUNT')

diff --git a/src/utils/computePriceImpact.test.ts b/src/utils/computePriceImpact.test.ts
@@ -12,7 +12,7 @@ describe('#computePriceImpact', () => {
     expect(
       computePriceImpact(
         new Price(Ether.onChain(1), t0, 10, 100),
-        CurrencyAmount.ether(1, 10),
+        CurrencyAmount.fromRawAmount(Ether.onChain(1), 10),
         CurrencyAmount.fromRawAmount(t0, 100)
       )
     ).toEqual(new Percent(0, 10000))