Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

Fix a crash when fetching annual data without a previous year #47

Conversation

JeremieCharest
Copy link
Contributor

@JeremieCharest JeremieCharest commented Dec 15, 2019

This PR fix a NPE when fetching annual data on a contract without previous year data (new contract or a move). It also fix a NPE when the CLI failed to authenticate and try to clean a non-existent session.

Steps to reproduce :

  • With a contract without previous data, invoke the cli with the following options :
    • -u xxx-user--xxx -p xxx-password-xxx -c xxx-14123-xxx -L INFO
    • it could also be reproduce with the -H option
  • Last logged line should contain Fetching annual data
  • An out of context 'compare' message should be printed

Expected behavior : The CLI should not crash and report the current year data

@titilambert titilambert merged commit 40352a2 into titilambert:master Dec 22, 2019
@titilambert
Copy link
Owner

Thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants