Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tina-lock.json info #1872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tina-lock.json info #1872

wants to merge 1 commit into from

Conversation

jaschaio
Copy link

See original PR on tinacms and discord discussion for reasoning why tina-lock.json should be mentioned within this section to prevent developers from running against a wall.

@jaschaio jaschaio requested a review from a team as a code owner June 30, 2024 04:14
Copy link

vercel bot commented Jun 30, 2024

@jaschaio is attempting to deploy a commit to the TinaCMS Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@ncn-ssw ncn-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proposed update - I have 1 suggestion.

@@ -260,4 +260,6 @@ export default defineConfig({
})
```

> Make sure you commit your changes to the config and [`tina-lock.json`](/docs/tina-folder/overview/#tina-lockjson) file at the same time as you push to production on tina.cloud as otherwise your assets will still be prefixed with `https://assets.tina.io` as if you were [still using repo based media](/docs/reference/media/repo-based/)
Copy link
Member

@ncn-ssw ncn-ssw Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use Tina Cloud's name rather than tina.cloud.

Suggested change
> Make sure you commit your changes to the config and [`tina-lock.json`](/docs/tina-folder/overview/#tina-lockjson) file at the same time as you push to production on tina.cloud as otherwise your assets will still be prefixed with `https://assets.tina.io` as if you were [still using repo based media](/docs/reference/media/repo-based/)
> Make sure you commit your changes to the config and [`tina-lock.json`](/docs/tina-folder/overview/#tina-lockjson) file at the same time as you push to production on TinaCloud as otherwise your assets will still be prefixed with `https://assets.tina.io` as if you were [still using repo based media](/docs/reference/media/repo-based/)

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ❌ Failed (Inspect) Jul 8, 2024 0:02am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants