Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle NA #2

Closed
timelyportfolio opened this issue Aug 29, 2016 · 1 comment
Closed

handle NA #2

timelyportfolio opened this issue Aug 29, 2016 · 1 comment

Comments

@timelyportfolio
Copy link
Owner

timelyportfolio commented Aug 29, 2016

I made a bad assumption, so NA are not treated properly. As a simple case,

d3r::d3_nest(
  data.frame(
    level1 = rep("a",3),
    level2 = c(NA,"a.1","a.2"),
    value = 1:3
  ),
  value_cols = "value"
)

image

In my mind proper behavior would be NA should not be nested as children. In the above example, value: 1 should not be in children, so should be promoted a level.

@timelyportfolio
Copy link
Owner Author

With example above, we now get two children and the value is promoted to the higher level.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant