This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
De-couple helpers from template #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'url' config option to pass a HttpUrl object to the helper used to calculate the url for each page
- Set the url for each page using the url object and offset and limit
- Rename link() to page()
BREAKING! The paginator link() method has been renamed to page() and the paginator now has a 'url' config option that needs to be used to create the url for each page. To migrate your code all template calls to the paginator should include array('url' => route());
- Add 'url' config option to sort() helper method to pass an HttpUrl object to the helper used to calculate the sort url
- Set the url for sorting based on the config options
BREAKING! The grid.sort helper now has a 'url' config option that needs to be used to create the url for sorting. To migrate your code all template calls to the grid.sort should include array('url' => route());
- Refactor the keepalive helper method to use jQuery and default to window.location.url - Add a 'url' config option to set a custom url to call - Use head requests and do not use cache
|
@ercanozkaya Can you review please ? |
| } | ||
| window.addEvent('domready', function() { Kodekit.keepalive.periodical('" . $refresh . "'); }); | ||
| </script>"; | ||
| (function keepalive(){ |
There was a problem hiding this comment.
to make it use setInterval:
(function($) {
var refresh = 123123123;
setInterval(function() {
$.ajax();
}, refresh*1000);
})(kQuery);```
There was a problem hiding this comment.
Fixed and tested. Anything else ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #77