-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Default Collapsed or Expanded #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to make the Expand
enable by default, without adding a new setting.
Two reasons:
- The purpose of this plugin is to render verses directly, the old
collapsailbe
(close by default) breaks this purpose, which need to be fixed (Thanks this PR) - There have been too many setting toggles, we should try not add more.
I somewhat agree, with the exception of mobile users - when inserting long passages (i.e. a whole chapter for some sermon topics), it can take up the majority, if not more than that, of the screen, which can get frustrating. For most desktop users and for small verses this isn't a problem but I do think having the option to insert small is a good idea
I agree that we have a lot of tagging ones but it seems like there are already changes in the works to deal with this; personally I'd always rather customizability over removing options. If you're adamant on this position, could I suggest a compromise of sorting the settings into collapsible toggles? (I'll also note I did want to make this toggle only visible when collapsible was enabled in the first place but didn't yet know how to do that; that's a change that could be implemented in a few other places too too simplify things, as part of a potential UI update pr later) |
@minermaniac447 thanks for understanding. Would you like to make the changes? If so, I will merge and make it happen in next release. |
Yep, I can put the change in. If you do want to revisit this idea later, let me know! |
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
Thanks, |
Implements #111; currently, the default setting is "expanded" (true). This could be changed to "collapsed" (false) to match current implementation.