add reference lookup command #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathonius
commented
Feb 6, 2023
| async getSuggestions( | ||
| context: EditorSuggestContext | ||
| ): Promise<VerseSuggesting[]> { | ||
| return getSuggestionsFromQuery(context.query, this.settings); |
There was a problem hiding this comment.
This was refactored out to VerseSuggestor.ts
nathonius
commented
Feb 6, 2023
| } | ||
|
|
||
| renderSuggestion(suggestion: VerseSuggesting, el: HTMLElement): void { | ||
| suggestion.renderSuggestion(el); |
There was a problem hiding this comment.
I moved the actual rendering of a suggestion to the suggestion itself so it could be shared between this and the modal.
nathonius
commented
Feb 6, 2023
tim-hub
reviewed
Feb 14, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * John12:1-3 | ||
| * John1:1 | ||
| */ | ||
| const modalReg = /([123])*[A-z]{3,}\d{1,3}\:\d{1,3}(\-\d{1,3})*/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
| ): Promise<VerseSuggesting[]> { | ||
| console.debug("get suggestion for query ", query.toLowerCase()); | ||
|
|
||
| const bookName = query.match(/[123]*[A-z]{3,}/)?.first(); |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
|
I did a bit refactoring after and now it is in :) Thanks so much |
tim-hub
added a commit
that referenced
this pull request
Feb 16, 2023
tim-hub
added a commit
that referenced
this pull request
Feb 16, 2023
|
I am thinking of instead of using maybe extend to |
|
@OfficerHalf ? What do you think of this idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--before the verse reference)Resolves #11 for me, anyway; technically the conflict still exists this just adds a new way to use the plugin. It only took me one year to finally get around to doing this and less than 24 hours to actually write it.
Let me know what you think.