Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the verse lookup command #80

Closed
tim-hub opened this issue Feb 17, 2023 · 6 comments · Fixed by #78
Closed

Extend the verse lookup command #80

tim-hub opened this issue Feb 17, 2023 · 6 comments · Fixed by #78
Labels
enhancement New feature or request improvement

Comments

@tim-hub
Copy link
Owner

tim-hub commented Feb 17, 2023

I am thinking of instead of using verse lookup as command

maybe extend to bible book chapter verse to be more direct

Originally posted by @tim-hub in #78 (comment)

So that the flow will be like.

  • CMD + P
  • John1:1 or ESVJohn1:1

to get the verse,

instead of

  • CMP + P
  • Verse Lookup
  • John1:1
@tim-hub tim-hub assigned tim-hub and unassigned tim-hub Feb 17, 2023
@tim-hub tim-hub added enhancement New feature or request improvement labels Feb 17, 2023
@tim-hub tim-hub linked a pull request Feb 17, 2023 that will close this issue
@nathonius
Copy link
Contributor

I feel like this breaks the convention of how Obsidian's commands work; if you wanted to accomplish this you could with the command as is, just bind it to a keyboard shortcut. What extra convenience would it provide?

@nathonius
Copy link
Contributor

I also don't think this would be mobile friendly. With the normal command you can add it to the mobile toolbar. With this sort of custom command flow, I'm not sure you could.

@stale
Copy link

stale bot commented Apr 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 22, 2023
@stale stale bot closed this as completed Apr 29, 2023
@tim-hub tim-hub removed the wontfix This will not be worked on label May 7, 2023
@tim-hub tim-hub reopened this May 7, 2023
@chrisg32
Copy link

chrisg32 commented May 8, 2023

I feel like this breaks the convention of how Obsidian's commands work; if you wanted to accomplish this you could with the command as is, just bind it to a keyboard shortcut. What extra convenience would it provide?

I agree. If you want to remove a step then assigning verse lookup as a hotkey solves that, i.e.:

  • CMD + R
  • John1:1

@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 9, 2023
@stale stale bot closed this as completed Jul 16, 2023
@tim-hub tim-hub reopened this Jul 16, 2023
@stale stale bot removed the wontfix This will not be worked on label Jul 16, 2023
@tim-hub
Copy link
Owner Author

tim-hub commented Aug 24, 2023

@chrisg32 @OfficerHalf

You are right, will close this for now.

@tim-hub tim-hub closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants