Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on mobile #55

Closed
ickc opened this issue Aug 20, 2022 · 13 comments
Closed

Does not work on mobile #55

ickc opened this issue Aug 20, 2022 · 13 comments
Labels
bug Something isn't working

Comments

@ickc
Copy link

ickc commented Aug 20, 2022

https://github.com/tim-hub/obsidian-bible-reference/blob/master/manifest.json#L9 seems to indicate that it would work on mobile, but when testing it on iPad and iPhone, it doesn't seem to work. Any idea? Thanks.

@russbonchu
Copy link

I would like to +1 this as it works fine on my Mac but nothing seems to happen on my iPhone. This would be fantastic on my phone as I take notes in church and this would be a great way to import the scripture references.

@russbonchu
Copy link

I am using Obsidian 1.3.1 (67) which is the latest version, and the plugin is up to date. i have tried several Bible versions and nothing happens. I would love to be able to use this in church with sermon notes.

@tim-hub
Copy link
Owner

tim-hub commented Sep 2, 2022

Oh, I haven't gotten an iOS device for testing, I only tried on Android, and it worked as on desktop, I am not sure, is it possible related to any iOS app policy?

@tim-hub tim-hub added the bug Something isn't working label Sep 2, 2022
@tim-hub tim-hub added this to the Get feedback and polish milestone Sep 2, 2022
@russbonchu
Copy link

russbonchu commented Sep 3, 2022 via email

@sword218
Copy link

Api:bible api can work on the phone,but API:Bolls can’t

@sword218
Copy link

3A7AA120-F268-4BAE-A9A5-54153AC2E632

@sword218
Copy link

57121591-0455-4DC6-B3F9-B44F9626CE7E

@BMonsalvatge
Copy link

BMonsalvatge commented Dec 4, 2022

I can't seem to get either API working for me at the moment.

Edit: on iOS 15. iPhone 11

@JPT62089
Copy link
Contributor

JPT62089 commented Jan 9, 2023

Just tested this out on my Pixel 6 Pro and ran into the same issue. Bible API works fine but Bolls does not. We'll have to see if there are any functions or something that aren't supported on Android.

Is anyone able to confirm if Bible API works for Apple devices? Or does neither work?

@JPT62089
Copy link
Contributor

Ok I was finally able to get some time to look into this further. On Android this appears to be an issue only with Bolls Life. The request is getting blocked by CORS policy as seen in the screenshot.

image

Access to fetch at 'https://bible-api-bff.bai.uno/bolls-life/ESV/43/1/' from origin 'http:https://localhost' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'app:https://obsidian.md' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@tim-hub, any reason why this is using https://bible-api-bff.bai.uno/bolls-life rather than https://bolls.life/get-text for the API URL? I changed my local main.js to the latter and it immediately worked perfectly on my android phone. In the meantime I might spin up a PR a change to the latter in case we want to switch to it over the current url

JPT62089 added a commit to JPT62089/obsidian-bible-reference that referenced this issue Jan 11, 2023
- [Fix] Update the Bolls Life URL to resolve the issue with Bolls Life not working on mobile tim-hub#55
@tim-hub
Copy link
Owner

tim-hub commented Jan 31, 2023

Ok I was finally able to get some time to look into this further. On Android this appears to be an issue only with Bolls Life. The request is getting blocked by CORS policy as seen in the screenshot.

image

Access to fetch at 'https://bible-api-bff.bai.uno/bolls-life/ESV/43/1/' from origin 'http:https://localhost' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'app:https://obsidian.md' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

@tim-hub, any reason why this is using https://bible-api-bff.bai.uno/bolls-life rather than https://bolls.life/get-text for the API URL? I changed my local main.js to the latter and it immediately worked perfectly on my android phone. In the meantime I might spin up a PR a change to the latter in case we want to switch to it over the current url

In the beginning of trying bolls like api, I found there was a CORS error stopping the plugin to consume it,

But it looks like the issue is gone now.

Thanks for raising up and testing on this. :)

@tim-hub
Copy link
Owner

tim-hub commented Jan 31, 2023

Thanks @JPT62089 for the PR

#73

the issues supposed to be fixed in release 1.4.0

@tim-hub
Copy link
Owner

tim-hub commented Jan 31, 2023

the issues supposed to be fixed in release 1.4.0 after PR #73

@tim-hub tim-hub closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants