Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for german bible names #168

Closed
blankton2 opened this issue Jan 4, 2024 · 3 comments
Closed

Add support for german bible names #168

blankton2 opened this issue Jan 4, 2024 · 3 comments
Labels
version for a spercific bible version

Comments

@blankton2
Copy link

  1. What language are you looking for?
    German

  2. What version is it?

  3. Do you know, is there a public bible API for it?

I wrote the de.json File for https://github.com/Antioch-Tech/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

Please add that file, so that we can use the german Names.
de.json

This is my first time submiting code, please be indulgent :)

@blankton2 blankton2 added the version for a spercific bible version label Jan 4, 2024
@tim-hub
Copy link
Owner

tim-hub commented Jan 4, 2024

Thanks so much.

Are you familiar with Git/Github? Do you mind creating a PR directly? :)

@blankton2
Copy link
Author

blankton2 commented Jan 4, 2024 via email

@blankton2
Copy link
Author

I made a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version for a spercific bible version
Projects
Status: Done
Development

No branches or pull requests

2 participants