Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two instances of undefined behavior in codec crate #7751

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix two instances of undefined behavior in codec crate #7751

wants to merge 6 commits into from

Commits on May 7, 2020

  1. codec: Fix undefined behavior in try_decode_first_internal 

    It is UB to construct out-of-bounds pointers.

Signed-off-by: Brian Anderson <[email protected]>
    @brson
    brson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    06c4f7d View commit details
    Browse the repository at this point in the history

  2. codec: Fix undefined behavior in try_decode_first tests 

    Previous code creates aliasing mutable slices.

Signed-off-by: Brian Anderson <[email protected]>
    @brson
    brson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    69b602a View commit details
    Browse the repository at this point in the history

  3. codec: Mark MemComparableByteCodec::try_decode_first_internal unsafe 

    Signed-off-by: Brian Anderson <[email protected]>
    @brson
    brson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    1f4afe4 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. codec: Add safety doc comment sto try_decode_first_internal 

    Signed-off-by: Brian Anderson <[email protected]>
    @brson
    brson committed May 10, 2020
    Configuration menu
    Copy the full SHA
    868f1e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into codec-ub

    @sre-bot
    sre-bot committed May 10, 2020
    Configuration menu
    Copy the full SHA
    6190b28 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Merge branch 'master' into codec-ub

    @sre-bot
    sre-bot committed May 11, 2020
    Configuration menu
    Copy the full SHA
    26cba0a View commit details
    Browse the repository at this point in the history