tidb_query: fix UB causing by from_raw_parts (#7635)
#7730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhongzc <[email protected]>
|
/run-all-tests |
sre-bot
added
sig/coprocessor
breezewish
approved these changes
May 3, 2020
|
/run-all-tests |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Signed-off-by: zhongzc <[email protected]>
|
/merge |
hicqu
approved these changes
May 14, 2020
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7635 to release-4.0
Signed-off-by: zhongzc [email protected]
What problem does this PR solve?
Issue Number: close #7613
Problem Summary:
From stdlib doc:
We didn't provide this promise.
What is changed and how it works?
What's Changed:
Introduce a new type
LEBytes. Implementbinary_searchfor this type by explicitly callingstd::ptr::read_unaligned.Check List
Tests
Release note