Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior #7709

Merged
merged 3 commits into from
Apr 30, 2020
Merged

tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior #7709

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff6b8bf
tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior
brson Apr 29, 2020
9ce05ff
Merge branch 'master' into vec-exec-ub
nrc Apr 30, 2020
f07201d
Merge branch 'master' into vec-exec-ub
sre-bot Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/tidb_query_vec_executors/src/slow_hash_aggr_executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
)?;
}

let buffer_ptr = (&*self.group_key_buffer).into();
for logical_row_idx in 0..logical_rows_len {
let offset_begin = self.group_key_buffer.len();

Expand Down Expand Up @@ -361,6 +360,7 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
}
}

let buffer_ptr = (&*self.group_key_buffer).into();
// Extra column is not included in `GroupKeyRefUnsafe` to avoid being aggr on.
let group_key_ref_unsafe = GroupKeyRefUnsafe {
buffer_ptr,
Expand Down