Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update ryu to 1.0.4 #7629

Merged
merged 1 commit into from
Apr 23, 2020
Merged

*: update ryu to 1.0.4 #7629

merged 1 commit into from
Apr 23, 2020

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 23, 2020

What problem does this PR solve?

This fixes some undefined behavior, but there's probably no practical impact.

See dtolnay/ryu#24

Signed-off-by: Brian Anderson [email protected]

What is changed and how it works?

Related changes

Check List

Release note

This fixes some undefined behavior, but there's probably no practical impact.

See dtolnay/ryu#24

Signed-off-by: Brian Anderson <[email protected]>
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BusyJay BusyJay added the status/can-merge Status: Can merge to base branch label Apr 23, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4eeb23e into tikv:master Apr 23, 2020
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Status: Can merge to base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants